I would certainly rather see this than {isAdmin: bool; isLoggedIn: bool}. With boolean | null, at least illegal states are unrepresentable... even if the legal states are represented in an... interesting way.

[–] nialv7@lemmy.world 2 points 8 hours ago (3 children)

Admin false LoggedIn false doesn't feel illegal to me, more redundant if anything

[–] shape_warrior_t@programming.dev 5 points 8 hours ago* (last edited 8 hours ago) (2 children)

I was thinking of the three legal states as:

not logged in (null or {isAdmin: false, isLoggedIn: false})
logged in as non-admin (false or {isAdmin: false, isLoggedIn: true})
logged in as admin (true or {isAdmin: true, isLoggedIn: true})

which leaves {isAdmin: true, isLoggedIn: false} as an invalid, nonsensical state. (How would you know the user's an admin if they're not logged in?) Of course, in a different context, all four states could potentially be distinctly meaningful.

[–] chocrates@piefed.world 1 points 4 hours ago

Honestly logged in is state and shouldn't be on the user object.

[–] nialv7@lemmy.world 2 points 5 hours ago

ah you are right! i am so dumb.

load more comments (14 replies)