I wouldn't say PR size is a bad metric, you usually just need yo read it the opposite of how sloppers do it, i.e. the most productive PRs are short and focused.

[–] Slotos@feddit.nl 2 points 1 day ago

I’m working with a legacy codebase for the last few months, where a simple PR often ends up crossing a 1000 lines count due to testing and commenting, and I can’t stop apologizing for those.

Yet there are people out there bragging about 10x changesets.

[–] RustyNova@lemmy.world 13 points 3 days ago (4 children)

Then Devs focus on minifying the code into an unreadable mess

[–] ViatorOmnium@piefed.social 18 points 2 days ago* (last edited 2 days ago)

I'm not saying it's a good individual metric. In fact, applying individual metrics to developers (or most workers really), will only land you in Goodhart's hell.

But as part of holistic operational health tracking, it's a useful team level metric, as there is ample evidence that shorter PRs tend to result in less operational issues. And, of course, this is only valid if you don't try to tie financial rewards to it, otherwise people will forget that PR size is a proxy measure for how easy changes are to review and rollback.

[–] KairuByte@lemmy.dbzer0.com 1 points 2 days ago

Yeah, I’ve been guilty of coming up with “cute” solutions that are extremely optimized and concise, but you needed to take a hundred times as long to work through what was going on.

Usually I would put an explanation comment, but sometimes a less optimized solution is the better option for readability sake.

[–] Shayeta@feddit.org 1 points 2 days ago

Hah, if those pesky devs think that they can play the system by just rolling up the code into a single line they got another thing coming - we're actually tracking PR character count, NOT LOC like some other companies!

[–] firelizzard@programming.dev 5 points 2 days ago (1 children)

PR size is an awful metric. The bigger the PR, the less reviewable it is.

[–] PoolloverNathan@programming.dev 5 points 2 days ago (1 children)

Yes, that's what the comment said — smaller PRs are better.

[–] firelizzard@programming.dev 4 points 2 days ago

PR size is still an awful metric. It should be within bounds but it should never be an actual metric. Treating it as a metric is an idiotic idea.