I'll give an example. At my previous company there was a program where you basically select a start date, select an end date, select the system and press a button and it reaches out to a database and pulls all the data following that matches those parameters. The horrors of this were 1. The queries were hard coded.

They were stored in a configuration file, in xml format.
The queries were not 1 entry. It was 4, a start, the part between start date and end date, the part between end date and system and then the end part. All of these were then concatenated in the program intermixed with variables.
This was then sent to the server as pure sql, no orm.
Here's my favorite part. You obviously don't want anyone modifying the configuration file so they encrypted it. Now I know what you're thinking at some point you probably will need to modify or add to the configuration so you store an unencrypted version in a secure location. Nope! The program had the ability to encrypt and decrypt but there were no visible buttons to access those functions. The program was written in winforms. You had to open the program in visual studio, manually expand the size of the window(locked size in regular use) and that shows the buttons. Now run the program in debug. Press the decrypt button. DO NOT EXIT THE PROGRAM! Edit the file in a text editor. Save file. Press the encrypt button. Copy the encrypted file to any other location on your computer. Close the program. Manually email the encrypted file to anybody using the file.

you are viewing a single comment's thread
view the rest of the comments

[–] HakFoo@lemmy.sdf.org 67 points 1 week ago (5 children)

Floats for currency in a payments platform.

The system will happily take a transaction for $121.765, and every so often there's a dispute because one report ran it through round() and another through floor().

[–] FishFace@piefed.social 11 points 1 week ago

Presumably every so often there's a dispute because 0 + (0.3 + 0.3 + 0.3) - 0.3 - 0.3 - 0.3 is not equal to 0 (in floating point arithmetic).

[–] bufalo1973@piefed.social 8 points 1 week ago

And not the easy way of using (long) integers to count the cents.

[–] RecallMadness@lemmy.nz 5 points 1 week ago

Lmao.

Using floats for nearly anything in a finance platform should be grounds for immediate dismissal.

[–] JackbyDev@programming.dev 4 points 1 week ago (1 children)

Did either of those do banker's rounding?

[–] psud@aussie.zone 1 points 1 week ago* (last edited 1 week ago)

Round is the safest way of using decimals for money as it corrects 10.499999999 (decimal fractions can't be stored precisely in floats as binary can't precisely represent all 2 digit decimals) to 10.50, where floor would take it to 10.49

It is safer to count in cents and have a policy to handle fractions of cents from divisions